Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Network port attach resource and deprecate macaddress property #5920

Merged
merged 2 commits into from
Jan 31, 2025
Merged

[Refactor] Network port attach resource and deprecate macaddress property #5920

merged 2 commits into from
Jan 31, 2025

Conversation

ismirlia
Copy link
Collaborator

Output from acceptance testing:

--- PASS: TestAccIBMPINetworkPortAttachbasic (843.69s)
PASS
--- PASS: TestAccIBMPINetworkPortAttachVlanbasic (973.17s)
PASS

Data source tests:

--- PASS: TestAccIBMPIInstanceIPDataSource_basic (29.26s)
PASS

--- PASS: TestAccIBMPINetworkPortDataSource_basic (15.28s)
PASS

@ismirlia ismirlia added the service/Power Systems Issues related to Power Systems label Jan 15, 2025
@ismirlia ismirlia mentioned this pull request Jan 16, 2025
Closed
yussufsh
yussufsh approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
.. but depreciation could have gone into a different PR.

@yussufsh yussufsh merged commit 24d8a4b into IBM-Cloud:master Jan 31, 2025
1 check passed
@yussufsh yussufsh deleted the network-port-attach branch January 31, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yussufsh yussufsh yussufsh approved these changes

@hkantare hkantare Awaiting requested review from hkantare

@michaelkad michaelkad Awaiting requested review from michaelkad

@Alexander-Kita Alexander-Kita Awaiting requested review from Alexander-Kita

Assignees
No one assigned
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ismirlia @yussufsh